Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent-operator: scaling strategies and configurable requirements #893

Merged
merged 7 commits into from
Apr 30, 2024
Merged

agent-operator: scaling strategies and configurable requirements #893

merged 7 commits into from
Apr 30, 2024

Conversation

ibodrov
Copy link
Collaborator

@ibodrov ibodrov commented Apr 23, 2024 •
edited
Loading

Rebase of https://github.com/brig/concord-k8s-operator-current
Additionally, instead of hard coding extra requirement filters we add a way to append arbitrary parameters to the query:

apiVersion: concord.walmartlabs.com/v1alpha1
kind: AgentPool
metadata:
  name: example-agentpool
spec:
  queueSelector:
    agent:
      # flavor: "banana" # the old way
    queryParams:
      - "requirements.agent.flavor.eq=banana"
      - "requirements.agent.spice.regexp=.*pepper"
# ...the rest of the definition

TODO:

  • port changes from brig/concord-k8s-operator-current
  • allow other requirements than flavor
  • urlencode queryParams elements

@ibodrov ibodrov added the wip Work in progress, do not merge label Apr 23, 2024
@ibodrov ibodrov force-pushed the ib/port-operator-changes branch from 213bae4 to f71c3d5 Compare April 23, 2024 18:48
@ibodrov ibodrov removed the wip Work in progress, do not merge label Apr 23, 2024
@ibodrov ibodrov requested a review from a team April 23, 2024 18:52
@ibodrov ibodrov added wip Work in progress, do not merge and removed wip Work in progress, do not merge labels Apr 23, 2024
@ibodrov ibodrov force-pushed the ib/port-operator-changes branch from 288ed3d to 6573e0d Compare April 29, 2024 20:46
@ibodrov ibodrov merged commit 60b2372 into master Apr 30, 2024
2 checks passed
@ibodrov ibodrov deleted the ib/port-operator-changes branch April 30, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brig brig brig approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibodrov @brig